chia7712 commented on code in PR #20451:
URL: https://github.com/apache/kafka/pull/20451#discussion_r2320005613
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -553,14 +553,18 @@ private void testInterceptors(Map<String, Object>
consumerConfig) throws Excepti
// commit sync and verify onCommit is called
var commitCountBefore =
MockConsumerInterceptor.ON_COMMIT_COUNT.intValue();
- consumer.commitSync(Map.of(TP, new OffsetAndMetadata(2L)));
- assertEquals(2, consumer.committed(Set.of(TP)).get(TP).offset());
+ consumer.commitSync(Map.of(TP, new OffsetAndMetadata(2L,
"metadata")));
+ OffsetAndMetadata metadata =
consumer.committed(Set.of(TP)).get(TP);
+ assertEquals(2, metadata.offset());
+ assertEquals("metadata", metadata.metadata());
assertEquals(commitCountBefore + 1,
MockConsumerInterceptor.ON_COMMIT_COUNT.intValue());
// commit async and verify onCommit is called
- var offsetsToCommit = Map.of(TP, new OffsetAndMetadata(5L));
+ var offsetsToCommit = Map.of(TP, new OffsetAndMetadata(5L,
"metadata"));
sendAndAwaitAsyncCommit(consumer, Optional.of(offsetsToCommit));
- assertEquals(5, consumer.committed(Set.of(TP)).get(TP).offset());
+ metadata = consumer.committed(Set.of(TP)).get(TP);
+ assertEquals(5, metadata.offset());
+ assertEquals("metadata", metadata.metadata());
Review Comment:
Please update the docs of `OffsetAndMetadata#metadata()` to remind that the
method never return `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
