chia7712 commented on code in PR #20492:
URL: https://github.com/apache/kafka/pull/20492#discussion_r2327675510
##########
docs/upgrade.html:
##########
@@ -136,9 +136,11 @@ <h5><a id="upgrade_420_notable"
href="#upgrade_420_notable">Notable changes in 4
settings.
</li>
<li>
- The <code>cleanup.policy</code> is empty and
<code>remote.storage.enable</code> is set to true, the
+ If <code>cleanup.policy</code> is empty and
<code>remote.storage.enable</code> is set to true, the
local log segments will be cleaned based on the values of
<code>log.local.retention.bytes</code> and
<code>log.local.retention.ms</code>.
+ <br>
+ Note that <code>cleanup.policy</code> supports empty values,
which means infinite retention.
Review Comment:
We could remind users that this use case is equivalent to setting
`retention.ms=-1` and `retention.bytes=-1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
