chia7712 commented on code in PR #20508:
URL: https://github.com/apache/kafka/pull/20508#discussion_r2335044297
##########
raft/src/main/java/org/apache/kafka/raft/EpochState.java:
##########
@@ -59,4 +59,9 @@ default Optional<LogOffsetMetadata> highWatermark() {
* User-friendly description of the state
*/
String name();
+
+ @Override
+ default void close() {
+ // intentionally left blank
Review Comment:
It seems the default implementation is unnecessary, since all subclasses
provide their own implementation. Could you also add comments explaining the
overrides?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
