[
https://issues.apache.org/jira/browse/KAFKA-7938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16775583#comment-16775583
]
ASF GitHub Bot commented on KAFKA-7938:
---------------------------------------
gwenshap commented on pull request #6312: KAFKA-7938: Fix test flakiness in
DeleteConsumerGroupsTest
URL: https://github.com/apache/kafka/pull/6312
Address the comments on PR-6307. Sorry for new PR, but one of the comments
was to move the PR to another branch.
****
This attempts to fix KAFKA-7938 and KAFKA-7946.
I removed two tests:
* testDeleteWithShortInitialization basically didn't check the result and
therefore always passed
* testDeleteCmdWithShortInitialization has no way to enforce that
initialization is indeed short, and therefore sometimes FAILED because the
group would be created before the CMD tried to delete it.
I thought the tests had limited value relative to the effort of figuring out
a way to make the timing work.
I also fixed testDeleteCmdNonEmptyGroup and testDeleteNonEmptyGroup so they
will validate that the group both exists and is non-empty before starting the
test itself. I also added some extra information for future debugging sessions
:)
I ran the tests LOTS of times to validate, but with flaky tests, it is hard
to tell :)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky Test DeleteConsumerGroupsTest#testDeleteCmdWithShortInitialization
> ------------------------------------------------------------------------
>
> Key: KAFKA-7938
> URL: https://issues.apache.org/jira/browse/KAFKA-7938
> Project: Kafka
> Issue Type: Bug
> Components: admin, unit tests
> Affects Versions: 2.2.0
> Reporter: Matthias J. Sax
> Assignee: Gwen Shapira
> Priority: Critical
> Fix For: 2.2.0
>
>
> To get stable nightly builds for `2.2` release, I create tickets for all
> observed test failures.
> https://builds.apache.org/blue/organizations/jenkins/kafka-2.2-jdk8/detail/kafka-2.2-jdk8/18/pipeline
> {quote}kafka.admin.DeleteConsumerGroupsTest >
> testDeleteCmdWithShortInitialization FAILED java.lang.AssertionError: The
> consumer group deletion did not work as expected at
> org.junit.Assert.fail(Assert.java:88) at
> org.junit.Assert.assertTrue(Assert.java:41) at
> kafka.admin.DeleteConsumerGroupsTest.testDeleteCmdWithShortInitialization(DeleteConsumerGroupsTest.scala:210){quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
