mimaison commented on code in PR #20518:
URL: https://github.com/apache/kafka/pull/20518#discussion_r2339146614
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -836,13 +836,7 @@ public class StreamsConfig extends AbstractConfig {
private static final String UPGRADE_FROM_DOC = "Allows live upgrading (and
downgrading in some cases -- see upgrade guide) in a backward compatible way.
Default is <code>null</code>. " +
"Please refer to the Kafka Streams upgrade guide for instructions on
how and when to use this config. " +
"Note that when upgrading from 3.5 to a newer version it is never
required to specify this config, " +
- "while upgrading live directly to 4.0+ from 2.3 or below is no longer
supported even with this config. " +
- "Accepted values are \"" + UPGRADE_FROM_24 + "\", \"" +
- UPGRADE_FROM_25 + "\", \"" + UPGRADE_FROM_26 + "\", \"" +
UPGRADE_FROM_27 + "\", \"" +
- UPGRADE_FROM_28 + "\", \"" + UPGRADE_FROM_30 + "\", \"" +
UPGRADE_FROM_31 + "\", \"" +
- UPGRADE_FROM_32 + "\", \"" + UPGRADE_FROM_33 + "\", \"" +
UPGRADE_FROM_34 + "\", \"" +
- UPGRADE_FROM_35 + "\", \"" + UPGRADE_FROM_36 + "\", \"" +
UPGRADE_FROM_37 + "\", \"" +
- UPGRADE_FROM_38 + "\", \"" + UPGRADE_FROM_39 + "\", \"" + "(for
upgrading from the corresponding old version).";
+ "while upgrading live directly to 4.0+ from 2.3 or below is no longer
supported even with this config.";
Review Comment:
> Thinking about this, it might actually be better to update
UpgradeFromValues and remove the old versions for which we don't support the
upgrade any longer?
I agree we should update the values passed to the Validator and any logic
around that instead of messing with the doc string. Let's open a ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
