frankvicky commented on code in PR #20530:
URL: https://github.com/apache/kafka/pull/20530#discussion_r2347302343
##########
clients/src/test/java/org/apache/kafka/common/record/FileRecordsTest.java:
##########
@@ -279,7 +279,7 @@ public void testSearch() throws IOException {
* Test that the message set iterator obeys start and end slicing
*/
@Test
- public void testIteratorWithLimits() throws IOException {
+ public void testIteratorWithLimits() {
Review Comment:
Some of the `FileRecords` are not closed during the test; should we also
clean them?
L368, L382
##########
clients/src/test/java/org/apache/kafka/common/replica/ReplicaSelectorTest.java:
##########
@@ -46,8 +46,8 @@ public void testSameRackSelector() {
ReplicaSelector selector = new RackAwareReplicaSelector();
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
