m1a2st commented on code in PR #20531:
URL: https://github.com/apache/kafka/pull/20531#discussion_r2347184454
##########
docs/connect.html:
##########
@@ -47,7 +47,7 @@ <h4><a id="connect_running" href="#connect_running">Running
Kafka Connect</a></h
<li><code>bootstrap.servers</code> - List of Kafka servers used to
bootstrap connections to Kafka</li>
<li><code>key.converter</code> - Converter class used to convert
between Kafka Connect format and the serialized form that is written to Kafka.
This controls the format of the keys in messages written to or read from Kafka,
and since this is independent of connectors it allows any connector to work
with any serialization format. Examples of common formats include JSON and
Avro.</li>
<li><code>value.converter</code> - Converter class used to convert
between Kafka Connect format and the serialized form that is written to Kafka.
This controls the format of the values in messages written to or read from
Kafka, and since this is independent of connectors it allows any connector to
work with any serialization format. Examples of common formats include JSON and
Avro.</li>
- <li><code>plugin.path</code> (default <code>empty</code>) - a list of
paths that contain Connect plugins (connectors, converters, transformations).
Before running quick starts, users must add the absolute path that contains the
example FileStreamSourceConnector and FileStreamSinkConnector packaged in
<code>connect-file-"version".jar</code>, because these connectors are not
included by default to the <code>CLASSPATH</code> or the
<code>plugin.path</code> of the Connect worker (see <a
href="#connectconfigs_plugin.path">plugin.path</a> property for examples).</li>
+ <li><code>plugin.path</code> (default <code>empty</code>) - a list of
paths that contain Connect plugins (connectors, converters, transformations).
Before running quick starts, users must add the absolute path that contains the
example FileStreamSourceConnector and FileStreamSinkConnector packaged in
<code>connect-file-{{fullDotVersion}}.jar</code>, because these connectors are
not included by default to the <code>CLASSPATH</code> or the
<code>plugin.path</code> of the Connect worker (see <a
href="#connectconfigs_plugin.path">plugin.path</a> property for examples).</li>
Review Comment:
The default value of `plugin.path` in `connect-standalone.properties` is not
`empty`. The actual default should be `null`, right?
https://github.com/apache/kafka/blob/962f4ada75cd1ac0a8d3bdd54fcd455a57c8943f/config/connect-standalone.properties#L41
https://github.com/apache/kafka/blob/962f4ada75cd1ac0a8d3bdd54fcd455a57c8943f/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java#L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
