chia7712 commented on code in PR #20542:
URL: https://github.com/apache/kafka/pull/20542#discussion_r2354862950
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java:
##########
@@ -1141,13 +1133,12 @@ public ConsumerGroupDescribeResponseData.DescribedGroup
asDescribedGroup(
*/
public static ConsumerGroup fromClassicGroup(
SnapshotRegistry snapshotRegistry,
- GroupCoordinatorMetricsShard metrics,
Review Comment:
Please update the documentation accordingly
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/ConsumerGroup.java:
##########
@@ -119,11 +118,6 @@ public String toLowerCaseString() {
*/
private final TimelineHashMap<String, Integer> serverAssignors;
- /**
- * The coordinator metrics.
- */
- private final GroupCoordinatorMetricsShard metrics;
Review Comment:
`StreamsGroup` also has this unused metrics. Since `StreamsGroup` is still
evolving, that should be fine for now.
cc @lucasbru
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
