chia7712 commented on code in PR #20479:
URL: https://github.com/apache/kafka/pull/20479#discussion_r2356026123
##########
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleShareConsumerOptions.java:
##########
@@ -71,7 +86,29 @@ public ConsoleShareConsumerOptions(String[] args) throws
IOException {
.describedAs("class")
.ofType(String.class)
.defaultsTo(DefaultMessageFormatter.class.getName());
- messageFormatterArgOpt = parser.accepts("property",
+ messageFormatterArgOptDeprecated = parser.accepts("property",
+ "(DEPRECATED) The properties to initialize the message
formatter. Default properties include: \n" +
+ " print.timestamp=true|false\n" +
+ " print.key=true|false\n" +
+ " print.offset=true|false\n" +
+ " print.delivery=true|false\n" +
+ " print.epoch=true|false\n" +
+ " print.partition=true|false\n" +
+ " print.headers=true|false\n" +
+ " print.value=true|false\n" +
+ " key.separator=<key.separator>\n" +
+ " line.separator=<line.separator>\n" +
+ " headers.separator=<line.separator>\n" +
Review Comment:
ditto
##########
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##########
@@ -100,7 +115,28 @@ public ConsoleConsumerOptions(String[] args) throws
IOException {
.describedAs("class")
.ofType(String.class)
.defaultsTo(DefaultMessageFormatter.class.getName());
- messageFormatterArgOpt = parser.accepts("property",
+ messageFormatterArgOptDeprecated = parser.accepts("property",
+ "(DEPRECATED) The properties to initialize the message
formatter. Default properties include: \n" +
+ " print.timestamp=true|false\n" +
+ " print.key=true|false\n" +
+ " print.offset=true|false\n" +
+ " print.epoch=true|false\n" +
+ " print.partition=true|false\n" +
+ " print.headers=true|false\n" +
+ " print.value=true|false\n" +
+ " key.separator=<key.separator>\n" +
+ " line.separator=<line.separator>\n" +
+ " headers.separator=<line.separator>\n" +
Review Comment:
typo: `line.separator` -> `headers.separator`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
