kevin-wu24 commented on PR #20551: URL: https://github.com/apache/kafka/pull/20551#issuecomment-3307303414
Thanks for the reviews @chia7712 @brandboat @frankvicky. Hopefully I can clear up the intended semantics of `--no-initial-controllers` a bit. > Should we consider deprecating --no-initial-controllers? It seems redundant and has no effect for either dynamic or static voter configurations. No, we should not deprecate `--no-initial-controllers`, since it does have an effect for a dynamic voter configuration, but not for static voter configuration. Specifically, when the static config `controller.quorum.voters` is not set in `kafka.properties`, one of --standalone, --initial-controllers, or --no-initial-controllers, must be set. Otherwise, the storage tool fails. This shows clear intention from the user to format a dynamic quorum. Actually, when we specify `--no-initial-controllers`, but do not specify `controller.quorum.voters` it is safe to assume kraft.version > 0, so I will update the PR accordingly. > Excuse me, what is the purpose of having both controller.quorum.voters and --no-initial-controllers when starting a static quorum cluster? > > I assumed --no-initial-controllers is used only in building a dynamic quorum cluster. `--no-initial-controllers` is only used in building a dynamic quorum cluster, meaning that when a node specifies `controller.quorum.voters` the flag acts as a no-op. However, specifying the flag should never break formatting because the meaning of --no-initial-controllers is that "this node may not know the intended KRaft version of cluster, and will rely on KRaft to figure out the version". This flag breaking previously valid static configurations is a regression from https://github.com/apache/kafka/pull/17836. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
