[ 
https://issues.apache.org/jira/browse/KAFKA-19724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18021595#comment-18021595
 ] 

Mikołaj Bul commented on KAFKA-19724:
-------------------------------------

Hi [~fatihcelik], thanks for your interest in solving the issue.

The problem I see is that {{GlobalStreamThread}} lacks handling for {{Error}} 
instances (e.g. {{ExceptionInInitializerError}} or 
{{{}UnsatisfiedLinkError{}}}). They aren't caught in 
{{streamsUncaughtExceptionHandler}} and propagate to 
{{{}Thread.UncaughtExceptionHandler{}}}, which might be a no-op. As a result 
the global thread can die silently.

Let's wait for [~mjsax]'s opinion, but I think it would be possible to handle 
it by implementing a {{Thread.UncaughtExceptionHandler}} for 
{{{}globalStreamThread{}}}, which logs the error and calls 
{{{}closeToError(){}}}, so that the stream can transition to {{ERROR}} state.

> Global stream thread ignores all exceptions
> -------------------------------------------
>
>                 Key: KAFKA-19724
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19724
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 3.4.0
>            Reporter: Mikołaj Bul
>            Assignee: Fatih Celik
>            Priority: Major
>              Labels: beginner, newbie
>
> {{globalStreamThread}} in {{KafkaStreams}} class ignores all exceptions and 
> fails to apply the user-provided {{StreamsUncaughtExceptionHandler}} in:
> {code:java}
> public void setUncaughtExceptionHandler(final StreamsUncaughtExceptionHandler 
> userStreamsUncaughtExceptionHandler)
> {code}
> This can lead to streams being stuck in faulty state after an exception is 
> thrown during their initialization phase (e.g. failure to load the RocksDB 
> native library). The exception isn't logged, so debugging such problem is 
> difficult.
> From my understanding of the {{b62d8b97}} commit message, the following code 
> is unnecessary as the {{globalStreamThread}} can't be replaced and the issue 
> description from KAFKA-12699 doesn't apply to it. Removing it should help.
> {code:java}
> if (globalStreamThread != null) {
>     globalStreamThread.setUncaughtExceptionHandler((t, e) -> { }
>     );
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to