dejan2609 commented on PR #19513:
URL: https://github.com/apache/kafka/pull/19513#issuecomment-3316119359
Update: an additional commit has been pushed (to polish some things).
I also did some testing (locally, on my laptop):
1. `./gradlew :jmh-benchmarks:shadowJar` :white_check_mark:
2. Create a distribution and test it:
- `./gradlew releaseTarGz`
- unpack (with `tar xvfz`)
**_/kafka/core/build/distributions/kafka_2.13-4.2.0-SNAPSHOT.tgz_**
- test number of files: `find kafka_2.13-4.2.0-SNAPSHOT -type f | wc
-l` -->> yields the same number of files as for the trunk distribution
:white_check_mark:
- test like here: https://kafka.apache.org/quickstart -->>
:white_check_mark:
___
Also, I revisited some previous shadow plugin related testing:
- https://github.com/apache/kafka/pull/15532
- https://github.com/apache/kafka/pull/18018#issuecomment-2645879873
**Testing procedure:**
- git checkout trunk
- change `gradle.properties` version to `4.2.0.1-SNAPSHOT`
- execute `./gradlew :clients:publishToMavenLocal -PskipSigning=true`
- git reset --hard
- git checkout KAFKA-19174
- change `gradle.properties` version to `4.2.0.2-SNAPSHOT`
- execute (again) `./gradlew :clients:publishToMavenLocal -PskipSigning=true`
Test results:
- compare two .pom file versions:
```
diff
~/.m2/repository/org/apache/kafka/kafka-clients/4.2.0.1-SNAPSHOT/kafka-clients-4.2.0.1-SNAPSHOT.pom
~/.m2/repository/org/apache/kafka/kafka-clients/4.2.0.2-SNAPSHOT/kafka-clients-4.2.0.2-SNAPSHOT.pom
6c6
< <version>4.2.0.1-SNAPSHOT</version>
---
> <version>4.2.0.2-SNAPSHOT</version>
```
- unzip both jar files:
~/.m2/repository/org/apache/kafka/kafka-clients/4.2.0.X-SNAPSHOT/kafka-clients-4.2.0.X-SNAPSHOT.jar:
`both META-INF/MANIFEST.MF` files contain only one line:
```
Manifest-Version: 1.0
```
- test dependencies in a real-life situation:
- use POC (used previously):
https://github.com/dejan2609/poc-kafka-18142.git
- switch between versions:
```
dependencies {
//implementation("org.apache.kafka:kafka-clients:4.2.0.1-SNAPSHOT")
implementation("org.apache.kafka:kafka-clients:4.2.0.2-SNAPSHOT")
}
```
- create two files and compare them
- `./gradlew dependencies > deps-trunk.txt`
- `./gradlew dependencies > deps-PR.txt`
- files are equivalent (i.e. Gradle dependencies trees match in everything
except for the `kafka-clients` version(s))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
