jack2012aa commented on PR #20536: URL: https://github.com/apache/kafka/pull/20536#issuecomment-3342221120
> This is a nice improvement but I wonder whether it could be even better with a bit of tweak. Here's an example of the current output. > > <img alt="Screenshot 2025-09-27 at 22 00 36" width="1019" height="672" src="https://private-user-images.githubusercontent.com/13795597/494792419-f760d697-0664-4d13-89c5-8acdac3b9916.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTkwMjEyMTksIm5iZiI6MTc1OTAyMDkxOSwicGF0aCI6Ii8xMzc5NTU5Ny80OTQ3OTI0MTktZjc2MGQ2OTctMDY2NC00ZDEzLTg5YzUtOGFjZGFjM2I5OTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTI4VDAwNTUxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MDBiNzViZjIwOTlmMTA0NDIxZjA0MTJlNzY5YmNhN2E3MGU2ODY1ZDY5ZWYyOGQ4ZTk3OWZkYjY1MWQyNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mC_RusFgoZDWqTLfngBAaSiu-BKRlnzSapwsicc4nXA";> > The part that could do with improvement is the table entries `__tagged_fields The tagged fields` rows in the table. It's all so nice now, apart from that. @AndrewJSchofield Thanks for the suggestion. Since the ticket didn't mention the table, I have few question on how to modify it. 1.Are there reasons why empty tagged fields are left in the table? Removing them is easy, but I want to make sure it is appropriate. 2. Should we remove the nested table of tagged fields, to make the format consist to the BNF? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/13795597/494792419-f760d697-0664-4d13-89c5-8acdac3b9916.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTkwMjEyMTksIm5iZiI6MTc1OTAyMDkxOSwicGF0aCI6Ii8xMzc5NTU5Ny80OTQ3OTI0MTktZjc2MGQ2OTctMDY2NC00ZDEzLTg5YzUtOGFjZGFjM2I5OTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTI4VDAwNTUxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MDBiNzViZjIwOTlmMTA0NDIxZjA0MTJlNzY5YmNhN2E3MGU2ODY1ZDY5ZWYyOGQ4ZTk3OWZkYjY1MWQyNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mC_RusFgoZDWqTLfngBAaSiu-BKRlnzSapwsicc4nXA"](https://private-user-images.githubusercontent.com/13795597/494792419-f760d697-0664-4d13-89c5-8acdac3b9916.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTkwMjEyMTksIm5iZiI6MTc1OTAyMDkxOSwicGF0aCI6Ii8xMzc5NTU5Ny80OTQ3OTI0MTktZjc2MGQ2OTctMDY2NC00ZDEzLTg5YzUtOGFjZGFjM2I5OTE2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MjglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTI4VDAwNTUxOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5MDBiNzViZjIwOTlmMTA0NDIxZjA0MTJlNzY5YmNhN2E3MGU2ODY1ZDY5ZWYyOGQ4ZTk3OWZkYjY1MWQyNzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.mC_RusFgoZDWqTLfngBAaSiu-BKRlnzSapwsicc4nXA"){kind=link}