chia7712 commented on code in PR #20248:
URL: https://github.com/apache/kafka/pull/20248#discussion_r2395108942
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -195,7 +190,7 @@ object StorageTool extends Logging {
): Unit = {
val releaseVersion =
Option(namespace.getString("release_version")).getOrElse(MetadataVersion.LATEST_PRODUCTION.toString)
try {
- val metadataVersion = MetadataVersion.fromVersionString(releaseVersion)
+ val metadataVersion = MetadataVersion.fromVersionString(releaseVersion,
true)
Review Comment:
This means we will need to add a subparser to accept an optional `--config`
flag for `ersion-mapping`. By default, `version-mapping` would display only
production-ready MVs. I believe this change would require a small KIP and could
be addressed by KAFKA-19749, which would ensure both tools have consistent
behavior.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
