chia7712 commented on code in PR #20561:
URL: https://github.com/apache/kafka/pull/20561#discussion_r2411218315
##########
.github/workflows/ci-complete.yml:
##########
@@ -43,8 +43,9 @@ jobs:
strategy:
fail-fast: false
matrix:
- # Make sure these match build.yml
- java: [ 24, 17 ]
+ # Make sure these match build.yml and also keep in mind that Java
version change in PR is not honored by CI
+ # (i.e. GitHub actions build will always use trunk branch version)
+ java: [ 25, 17 ]
Review Comment:
This will be a issue to other active branches. I open
https://issues.apache.org/jira/browse/KAFKA-19768 to fix it.
##########
.github/workflows/ci-complete.yml:
##########
@@ -43,8 +43,9 @@ jobs:
strategy:
fail-fast: false
matrix:
- # Make sure these match build.yml
- java: [ 24, 17 ]
+ # Make sure these match build.yml and also keep in mind that Java
version change in PR is not honored by CI
Review Comment:
Would you mind merging them into single line? for example
```
Make sure these match build.yml and also keep in mind that GitHub Actions
build will always use this file from the trunk branch.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
