lianetm commented on code in PR #20521:
URL: https://github.com/apache/kafka/pull/20521#discussion_r2414321005
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -810,7 +809,7 @@ private void
testPerPartitionLeadMetricsCleanUpWithSubscribe(
// Create a consumer and consumer some messages.
var listener = new TestConsumerReassignmentListener();
consumer.subscribe(List.of(TOPIC, topic2), listener);
- var records = awaitNonEmptyRecords(consumer, TP);
+ var records = ConsumerPollTestUtils.waitForRecords(consumer);
Review Comment:
trying to understand the need for this change, I don't see why the previous
`awaitNonEmptyRecords` wouldn't work (maybe needs just a tweak on the poll
timeout, to ensure it runs several before the `waitForCondition` expires? that
would make sense to me, because with the current pollTimeout of 10 Second it
will only have time for 1 run, because `waitForCondition` expired on 15s)
Also note that our change here is not exactly the same we had (as it won't
validate that the records are from the given partition)
(I'm keen on fully understanding these kind of changes, to make sure we're
not hiding an issue with the changes on how long we block on poll)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
