mjsax commented on code in PR #20664:
URL: https://github.com/apache/kafka/pull/20664#discussion_r2415247328


##########
tools/src/test/java/org/apache/kafka/tools/TopicCommandTest.java:
##########
@@ -1198,7 +1198,7 @@ public void 
testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress(Cl
                     "Unexpected describe output length: " + 
simpleDescribeOutputRows.length);
 
             String underReplicatedOutput = 
captureDescribeTopicStandardOut(clusterInstance, 
buildTopicCommandOptionsWithBootstrap(clusterInstance, "--describe", 
"--under-replicated-partitions"));
-            assertEquals("", underReplicatedOutput,
+            assertFalse(underReplicatedOutput.contains(String.format("Topic: 
%s", testTopicName)),
                     String.format("--under-replicated-partitions shouldn't 
return anything: '%s'", underReplicatedOutput));

Review Comment:
   Nit: seems the error message would need an update, too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to