joshua2519 commented on code in PR #20658:
URL: https://github.com/apache/kafka/pull/20658#discussion_r2419975467
##########
wrapper.gradle:
##########
@@ -42,9 +42,11 @@ task bootstrapWrapper() {
// fetch the jar.
def wrapperBaseUrl =
"https://raw.githubusercontent.com/gradle/gradle/v$versions.gradle/gradle/wrapper";
def wrapperJarUrl = wrapperBaseUrl + "/gradle-wrapper.jar"
+ def wrapperJarChecksumUrl =
"https://services.gradle.org/distributions/gradle-$versions.gradle-wrapper.jar.sha256";
def bootstrapString = """
# Loop in case we encounter an error.
+ REQUIRED_WRAPPER_JAR_CHECKSUM=\$(curl -sSL "$wrapperJarChecksumUrl")
Review Comment:
Thanks for that. Considering that Gradle version updates are infrequent,
hardcoding the SHA is a much more efficient method than retrieving the checksum
every time. I've included a code comment to ensure the checksum is also updated
whenever we perform a Gradle version upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
