aheev commented on PR #20385: URL: https://github.com/apache/kafka/pull/20385#issuecomment-3345766622
> Hi @AndrewJSchofield , > > I noticed 36 rename refactoring in your [recent commit](https://github.com/apache/kafka/commit/dbe9d34e47452059b78a73f782c4911ec7e366f7): > > * Variable Declaration Statement messagesReadByConsumer -> recordsReadByConsumer. > * Single Variable Declaration totalMessagesRead -> totalRecordsRead. > * Method Declaration updateMessagesConsumed -> updateRecordsConsumed. > * Method Declaration numMessages -> numRecords. > * Single Variable Declaration messagesRead -> recordsRead. > * Field Declaration messagesConsumed -> recordsConsumed. > * Single Variable Declaration lastMessagesRead -> lastRecordsRead. > * Variable Declaration Statement messagesRead -> recordsRead. > * Variable Declaration Statement totalMessagesRead -> totalRecordsRead. > * Variable Declaration Statement numMessages -> numRecords. > * Variable Declaration Statement lastMessagesRead -> lastRecordsRead. > * Method Declaration messagesConsumed -> recordsConsumed. > * Variable Declaration Statement intervalMessagesRead -> intervalRecordsRead. > * Single Variable Declaration messagesConsumed -> recordsConsumed. > * Method Declaration consumeMessagesForSingleShareConsumer -> - consumeRecordsForSingleShareConsumer. > * Variable Declaration Statement intervalMessagesPerSec -> intervalRecordsPerSec. > > How did you identify that these 36 elements were connected and should be renamed together? > > * Did you find this task challenging in any way? > * Did you perform the renames manually or with tools? > * Would it be helpful if tools could detect and rename connected program elements together instead of one by one? We wanted to get rid of `message` naming convention in tests, so while I was going through the tests, I just a did a search and replace for `message` keyword. Delegating the task to an AI agent would have been simpler though Can I know what's the motive behind your query? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
