kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2433217087


##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########


Review Comment:
   There is a clearer way to make these changes. This method is what writes the 
`0-0.checkpoint` currently. We should pass the bootstrap metadata object here 
and append the metadata records using 
`writer.append.append(bootstrapMetadata.records())` before calling 
`writer.freeze()`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to