mjsax commented on code in PR #20605:
URL: https://github.com/apache/kafka/pull/20605#discussion_r2386497964
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionReceiveProcessorSupplier.java:
##########
@@ -82,7 +82,8 @@ public void init(final ProcessorContext<CombinedKey<KRight,
KLeft>, Change<Value
@Override
public void process(final Record<KRight,
SubscriptionWrapper<KLeft>> record) {
- if (record.key() == null &&
!SubscriptionWrapper.Instruction.PROPAGATE_NULL_IF_NO_FK_VAL_AVAILABLE.equals(record.value().instruction()))
{
+ final KRight foreignKey = record.key();
Review Comment:
Minor cleanup, to explain that `record.key()` is the FK -- it's not
necessarily obvious form the existing code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
