kirktrue commented on code in PR #20521:
URL: https://github.com/apache/kafka/pull/20521#discussion_r2422147542
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -210,6 +210,30 @@ boolean doSend(final UnsentRequest r, final long
currentTimeMs) {
}
ClientRequest request = makeClientRequest(r, node, currentTimeMs);
if (!client.ready(node, currentTimeMs)) {
+ AuthenticationException authenticationException =
client.authenticationException(node);
+
+ // The client may not be ready because it hit an unrecoverable
authentication error. In that case, there's
+ // no benefit from retrying, so propagate the error here.
Review Comment:
The failing test is
`SaslClientsWithInvalidCredentialsTest.testManualAssignmentConsumerWithAuthenticationFailure()`.
As mentioned above, the test fails because the authentication error isn't
thrown. On `trunk`, the error thrown from the _blocking_ call to
`CheckAndUpdateFetchPositions`. However, this branch removes that explicit
event and does not block there. The error should show up in the
`AsyncPollEvent` and be thrown in `checkInflightPoll()`. I have to find out why
it's not...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
