chia7712 commented on code in PR #20695:
URL: https://github.com/apache/kafka/pull/20695#discussion_r2426326589
##########
build.gradle:
##########
@@ -136,6 +136,12 @@ ext {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
options.compilerArgs << "-Werror"
+ if (userKeepAliveMode == KeepAliveMode.SESSION){
+ // Suppress warning triggered under keepAliveMode=SESSION during joint
compilation
+ // Unexpected javac output: warning: [path] bad path element
".../core/build/classes/java/main": no such file or directory
Review Comment:
Could you remove the unnecessary spaces?
##########
build.gradle:
##########
@@ -136,6 +136,12 @@ ext {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
options.compilerArgs << "-Werror"
+ if (userKeepAliveMode == KeepAliveMode.SESSION){
+ // Suppress warning triggered under keepAliveMode=SESSION during joint
compilation
+ // Unexpected javac output: warning: [path] bad path element
".../core/build/classes/java/main": no such file or directory
+ // This becomes an error under -Werror
Review Comment:
this line seems to a bit redundant. would you mind removing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
