chia7712 commented on code in PR #20607:
URL: https://github.com/apache/kafka/pull/20607#discussion_r2398841479
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -690,10 +694,14 @@ class UnifiedLogTest {
def testLogSegmentsCallCorrect(): Unit = {
// Create 3 segments and make sure we get the right values from various
logSegments calls.
def createRecords = TestUtils.singletonRecords(value = "test".getBytes,
timestamp = mockTime.milliseconds)
- def getSegmentOffsets(log :UnifiedLog, from: Long, to: Long) =
log.logSegments(from, to).map { _.baseOffset }
+
+ def getSegmentOffsets(log: UnifiedLog, from: Long, to: Long) =
log.logSegments(from, to).map {
Review Comment:
ditto. mind keeping it the same as trunk?
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -427,12 +428,12 @@ class UnifiedLogTest {
val log = createLog(logDir, logConfig)
def assertProducerState(
- producerId: Long,
- producerEpoch: Short,
- lastSequence: Int,
- currentTxnStartOffset: Option[Long],
- coordinatorEpoch: Option[Int]
- ): Unit = {
+ producerId: Long,
Review Comment:
Mind reverting this? I think it was accidentally done by the auto-formatter.
:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
