satishd commented on code in PR #20706:
URL: https://github.com/apache/kafka/pull/20706#discussion_r2434532120


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -1675,7 +1675,7 @@ class ReplicaManager(val config: KafkaConfig,
     var errorReadingData = false
 
     // topic-partitions that have to be read from remote storage
-    val remoteFetchInfos = new util.HashMap[TopicIdPartition, 
RemoteStorageFetchInfo]()
+    val remoteFetchInfos = new util.LinkedHashMap[TopicIdPartition, 
RemoteStorageFetchInfo]()

Review Comment:
   Good to have this as LinkedHashMap so that we try processing the topic 
partitions in the order sent by the client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to