chia7712 commented on code in PR #20432:
URL: https://github.com/apache/kafka/pull/20432#discussion_r2378185982
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/TxnMetadata.java:
##########
@@ -39,13 +39,4 @@ public TxnMetadata(long producerId, long firstOffset) {
public TxnMetadata(long producerId, LogOffsetMetadata firstOffset) {
this(producerId, firstOffset, OptionalLong.empty());
}
-
- @Override
Review Comment:
ditto
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogToClean.java:
##########
@@ -94,43 +93,4 @@ public double cleanableRatio() {
public int compareTo(LogToClean that) {
return Double.compare(this.cleanableRatio, that.cleanableRatio);
}
-
- @Override
- public boolean equals(Object o) {
Review Comment:
Excuse me, why to remove those methods? `LogToClean` is not a record class,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
