mkansara23 commented on PR #20551: URL: https://github.com/apache/kafka/pull/20551#issuecomment-3344833796
Hi @kevin-wu24 , I noticed 5 rename refactoring in your [recent commit](https://github.com/apache/kafka/commit/857b1e92cc5c75eb178e48613e5963755bc1b03b): - Method Declaration testFormatWithoutInitialVotersFailsWithNewerKraftVersion -> - testFormatWithStaticQuorumFailsWithNewerKraftVersion. - Single Variable Declaration noInitialControllersFlag -> hasDynamicQuorum. - Method Declaration setNoInitialControllersFlag -> setHasDynamicQuorum. - Method Declaration testFormatWithInitialVotersFailsWithOlderMetadataVersion -> - testFormatWithInitialVotersWithOlderMetadataVersion. - Field Declaration noInitialControllersFlag -> hasDynamicQuorum. How did you identify that these 5 elements were connected and should be renamed together? - Did you find this task challenging in any way? - Did you perform the renames manually or with tools? - Would it be helpful if tools could detect and rename connected program elements together instead of one by one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
