apoorvmittal10 commented on code in PR #20661:
URL: https://github.com/apache/kafka/pull/20661#discussion_r2433999697
##########
clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java:
##########
@@ -528,13 +529,13 @@ public void handleResponse(PushTelemetryResponse
response) {
@Override
public void
handleFailedGetTelemetrySubscriptionsRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the get telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
}
@Override
public void handleFailedPushTelemetryRequest(KafkaException
maybeFatalException) {
log.debug("The broker generated an error for the push telemetry
network API request", maybeFatalException);
- handleFailedRequest(maybeFatalException != null);
+ handleFailedRequest(isRetryable(maybeFatalException));
Review Comment:
Yeah, I agree to both. For the issue pointed by @mjsax, AFAIR, that was a
common issue in code and not specific to telemetry, the log comes in debug
mode. The current PR issue gets highlighted as it logs in WARN and do not
differentiate with `UnsupportedVersionException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
