chia7712 commented on code in PR #20728:
URL: https://github.com/apache/kafka/pull/20728#discussion_r2445324112
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerGroupMetadata.java:
##########
@@ -31,6 +31,10 @@ public class ConsumerGroupMetadata {
private final String memberId;
private final Optional<String> groupInstanceId;
+ /**
+ * @deprecated Since 4.2, please use {@link KafkaConsumer#groupMetadata()}
instead. This class will be an interface in Kafka 5.0.
+ */
+ @Deprecated(since = "4.2", forRemoval = true)
Review Comment:
Those changes cause following warnings.
```
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java:323:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
assignor.onAssignment(new
ConsumerPartitionAssignor.Assignment(ownedPartitionsInUserdata), new
ConsumerGroupMetadata(groupId, generationId, consumer1, Optional.empty()));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:1385:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
final ConsumerGroupMetadata groupMetadataAfterUnsubscribe = new
ConsumerGroupMetadata(
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:63:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
assignor.onAssignment(new
ConsumerPartitionAssignor.Assignment(partitions), new
ConsumerGroupMetadata(groupId, generationId, consumer1, Optional.empty()));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:74:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
assignor.onAssignment(new
ConsumerPartitionAssignor.Assignment(partitions), new
ConsumerGroupMetadata(groupId, generationId, consumer1, Optional.empty()));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:87:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
assignor.onAssignment(null, new
ConsumerGroupMetadata("dummy-group-id", generation, "dummy-member-id",
Optional.empty()));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java:149:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
assignor.onAssignment(new
ConsumerPartitionAssignor.Assignment(ownedPartitionsInUserdata), new
ConsumerGroupMetadata(groupId, generationId, consumer1, Optional.empty()));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:2005:
warning: [removal] ConsumerGroupMetadata(String) in ConsumerGroupMetadata has
been deprecated and marked for removal
producer.sendOffsetsToTransaction(Collections.emptyMap(), new
ConsumerGroupMetadata(groupId));
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:2231:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
ConsumerGroupMetadata groupMetadata = new
ConsumerGroupMetadata(groupId,
^
/home/chia7712/project/kafka/clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:2246:
warning: [removal] ConsumerGroupMetadata(String,int,String,Optional<String>)
in ConsumerGroupMetadata has been deprecated and marked for removal
verifyInvalidGroupMetadata(new ConsumerGroupMetadata("group", 2,
JoinGroupRequest.UNKNOWN_MEMBER_ID, Optional.empty()));
```
I assume these will be fixed when the new interface is introduced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
