see-quick commented on code in PR #20672:
URL: https://github.com/apache/kafka/pull/20672#discussion_r2447434087
##########
server/src/main/java/org/apache/kafka/server/metrics/ClientTelemetryPlugin.java:
##########
@@ -18,40 +18,60 @@
import org.apache.kafka.common.requests.PushTelemetryRequest;
import org.apache.kafka.common.requests.RequestContext;
+import org.apache.kafka.server.telemetry.ClientTelemetryExporter;
import org.apache.kafka.server.telemetry.ClientTelemetryReceiver;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
/**
- * Plugin to register client telemetry receivers and export metrics. This
class is used by the Kafka
- * server to export client metrics to the registered receivers.
+ * Plugin to register client telemetry receivers/exporters and export metrics.
This class is used by the Kafka
+ * server to export client metrics to the registered receivers and exporters,
supporting both the deprecated
+ * {@link ClientTelemetryReceiver} and the new {@link ClientTelemetryExporter}
interfaces.
*/
-public class ClientMetricsReceiverPlugin {
+@SuppressWarnings({"deprecation", "overloads"})
+public class ClientTelemetryPlugin {
Review Comment:
Yeah. I am fine with `ClientTelemetryExporterPlugin` also. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
