mjsax commented on code in PR #20735:
URL: https://github.com/apache/kafka/pull/20735#discussion_r2449106870
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1587,11 +1587,15 @@ public void handleStreamsRebalanceData() {
}
private void handleMissingSourceTopicsWithTimeout(final String
missingTopicsDetail) {
+ // Determine the timeout: use 2 * heartbeatIntervalMs
Review Comment:
This comment just says, what the code does (-> `timeoutMs = 2 *
heartbeatIntervalMs`) -- it does not add any knowledge. -- Either remove it, or
say _why_ we need to use `2* heartbeatIntervalMs` as timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
