lianetm commented on PR #20362:
URL: https://github.com/apache/kafka/pull/20362#issuecomment-3429733926

   Hey @chickenchickenlove , thanks for looking in to this, interesting. Help 
me understand this issue better (the proposed change is harmless as I see it 
and could fix the flakiness, but want to make sure it is not hiding something 
else). 
   
   High level, from the consumer POV, the 2 sides involved happen in the 
background (so safe there):
   - updating assignment when a reconciliation completes (topic delete)
   - process unsubscribe
   
   So how exactly do we end up in step 8??? Is it that the partitions passed to 
the unsubscribe here (taken from the `currentAssignment`) are not in the 
`subscriptionState` anymore? 
   
https://github.com/apache/kafka/blob/05999c70c14ed998e4c0bc19ade1518bdc3df748/clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java#L921
   
   This bit it different between streams and the consumer mgrs actually (the 
partitions to revoked passed in the consumer are taken directly from the 
subscriptionState, not from the currentAssignment like the streamsMgr does)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to