DL1231 commented on PR #20614:
URL: https://github.com/apache/kafka/pull/20614#issuecomment-3431520353
@junrao : Thanks for your review.
> 1. Is it possible to pick one approach to implement all nullable types in
a consistent way?
I think (c) might be more suitable, as it not only allows for more code
reuse but also enables better separation of logic between nullable and
non-nullable types.
What do you think about addressing this issue in a separate PR? The changes
required to modify the implementation of all nullable types might be a bit more
involved.
> 2. In the generated html, could we introduce notations for 4 different
types of arrays (nullable vs non-nullable, compact vs non-compact)?
How about adding the array type after the []? For example:
<pre>ConsumerGroupHeartbeat Response (Version: 0) => throttle_time_ms
error_code error_message member_id member_epoch heartbeat_interval_ms
assignment _tagged_fields
throttle_time_ms => INT32
error_code => INT16
error_message => COMPACT_NULLABLE_STRING
member_id => COMPACT_NULLABLE_STRING
member_epoch => INT32
heartbeat_interval_ms => INT32
assignment => NULLABLE_STRUCT [topic_partitions]COMPACT_ARRAY
_tagged_fields
topic_partitions => STRUCT topic_id [partitions]COMPACT_ARRAY
_tagged_fields
topic_id => UUID
partitions => INT32
</pre>
> 3. All static classes in Field except TaggedFieldsSection are not really
being used. We can probably remove them.
Filed [KAFKA-19822](https://issues.apache.org/jira/browse/KAFKA-19822) to
track this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
