lucasbru commented on code in PR #20755:
URL: https://github.com/apache/kafka/pull/20755#discussion_r2454986110
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -290,6 +290,10 @@ public class GroupCoordinatorConfig {
public static final int STREAMS_GROUP_MAX_STANDBY_REPLICAS_DEFAULT = 2;
public static final String STREAMS_GROUP_MAX_STANDBY_REPLICAS_DOC = "The
maximum allowed value for the group-level configuration of " +
GroupConfig.STREAMS_NUM_STANDBY_REPLICAS_CONFIG;
+ public static final String STREAMS_GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG
= "group.streams.initial.rebalance.delay.ms";
+ public static final int STREAMS_GROUP_INITIAL_REBALANCE_DELAY_MS_DEFAULT =
3000;
Review Comment:
@mjsax Are we good with a default of 3 seconds for delaying the initial
rebalance?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -961,4 +968,11 @@ public int streamsGroupNumStandbyReplicas() {
public int streamsGroupMaxNumStandbyReplicas() {
return streamsGroupMaxStandbyReplicas;
}
+
+ /**
+ * The initial rebalance delay for streams groups.
+ */
+ public int streamsGroupInitialRebalanceDelayMs() {
Review Comment:
I would not introduce completely unused things in PRs. It may be better to
extend this PR to actually make use of the configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
