majialoong commented on PR #20789: URL: https://github.com/apache/kafka/pull/20789#issuecomment-3469328988
The following are the contents of this PR change and the reasons I considered when making the changes. | File | Changes | Reason | |------|---------|--------| | checkstyle.xml | Removed `<module name="EmptyStatement"/>` | Duplicate with rule at line 50. | | import-control.xml | Removed `<allow pkg="org.apache.kafka.common" exact-match="true" />` from `common` subpackage | Already defined in parent level | | | Removed `<allow pkg="org.apache.message" />` from `message` subpackage | **`org.apache.message` is not found in the current project**. | | | **Removed `streams.perf` subpackage** | **This package cannot be found in the current project**. | | import-control-clients-integration-tests.xml | Removed `<allow pkg="org.junit"/>` | Duplicate with rule at line 23 | | | Removed class from `<allow pkg="org.apache.kafka.clients" class="CommonClientConfigs"/>` | This appears to be incorrect usage, the effective attribute should be pkg, not class | | | Removed class from `<allow pkg="org.mockito" class="AssignmentsManagerTest"/>` | ditto | | | Removed class from `<allow pkg="org.opentest4j" class="RemoteLogManagerTest"/>` | ditto | | import-control-core.xml | Added `exact-match=true` to `<allow pkg="org.apache.kafka.common" />` | To avoid allowing too many rules and maintain consistent behavior with other import files. | | | Added `<allow pkg="org.apache.kafka.common.utils" />` | Added a required common package | | | **Removed `kafka.test` subpackage and its rules** | **`kafka.test` package does not exist in the current projec**t | | | Removed `<allow pkg="org.apache.kafka.common.test.api"/>` from `admin` subpackage | Already defined in parent level | | | **Removed `kafka.clients`** | **`kafka.clients` package does not exist in the current project** | | import-control-jmh-benchmarks.xml | Removed `<allow class="kafka.utils.KafkaScheduler"/>` | `kafka.utils.KafkaScheduler class` does not exist in the current project | | | Removed `<allow class="org.apache.kafka.clients.FetchSessionHandler"/>` | Since `<allow pkg="org.apache.kafka.clients"/>` rule has been added, no need to import this class separately | | import-control-metadata.xml | **Removed `<allow pkg="org.apache.kafka.metadata.migration" />` from `controller` subpackage** |**` org.apache.kafka.metadata.migration` does not exist in the current project** | | | **Removed `metadata.fault` subpackage and its rules** | **`org.apache.kafka.metadata.fault` does not exist in the project**. | | | **Removed `metadata.migration` subpackage and its rules** | **`org.apache.kafka.metadata.migration` does not exist in the project**. | | import-control-server.xml | Removed `<allow pkg="org.apache.kafka.server.metrics" />` | This rule is defined duplicately | | import-control-server-common.xml | Added `exact-match=true` to `<allow pkg="org.apache.kafka.common" />` | To avoid allowing too many rules and maintain consistent behavior with other import files. | | | Removed `<allow pkg="javax.crypto" />` and `<allow pkg="javax.crypto.spec" />` from `security` subpackage | `<allow pkg="javax.crypto" />` is already defined in parent level | | | Added `config` subpackage and `<allow class="org.apache.kafka.common.config.AbstractConfig" />` rule | Since the entire common and subpackages were previously allowed, now constraints are applied to the common package | | import-control-share-coordinator.xml | Removed `<allow pkg="org.junit.jupiter.provider"/>` from `coordinator.share` subpackage | `org.junit.jupiter.provider` is an incorrect path, it should actually be `org.junit.jupiter.params.provider`, but `org.junit.jupiter.params` has already been defined above, which includes `org.junit.jupiter.params.provider`, so this rule can be removed. | | | Removed `<allow pkg="org.apache.kafka.timeline" />` from `coordinator.share.metrics` subpackage | Already defined in parent level | | import-control-storage.xml | Removed `<allow pkg="org.apache.kafka.common.test" />` from `server.log` and `server.log.remote.storage` subpackages | Already defined in parent level | | | Removed class from` <allow pkg="org.apache.kafka.clients.admin" class="Admin" />` in `tiered.storage.admin` subpackage | This appears to be incorrect usage, the effective attribute should be pkg, not class | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
