FrankYang0529 commented on code in PR #20674:
URL: https://github.com/apache/kafka/pull/20674#discussion_r2479975858
##########
clients/src/main/java/org/apache/kafka/clients/admin/DescribeFeaturesOptions.java:
##########
@@ -16,8 +16,27 @@
*/
package org.apache.kafka.clients.admin;
+import java.util.OptionalInt;
+
/**
* Options for {@link AdminClient#describeFeatures(DescribeFeaturesOptions)}.
*/
public class DescribeFeaturesOptions extends
AbstractOptions<DescribeFeaturesOptions> {
+ private OptionalInt nodeId = OptionalInt.empty();
+
+ /**
+ * Set the node id to which the request should be sent.
+ */
Review Comment:
The `--bootstrap-controller` and `--bootstrap-broker` are flags in the
command. It's not about `Admin`.
For `Admin` interface, it's better to use `bootstrap.controllers` and
`bootstrap.servers`. In related document, it already points out the
`bootstrap.controllers` builds connection to KRaft controller quorum and
`bootstrap.servers` builds connection to Kafka brokers.
https://github.com/apache/kafka/blob/53e117253d21b2cd00e69d6ab91dae0ee84432f2/clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java#L56-L58
https://github.com/apache/kafka/blob/53e117253d21b2cd00e69d6ab91dae0ee84432f2/clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java#L46-L48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
