AndrewJSchofield commented on code in PR #20802:
URL: https://github.com/apache/kafka/pull/20802#discussion_r2482275674
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -6382,9 +6382,9 @@ public void testLsoMovementPostGapsInAcknowledgements() {
fetchAcquiredRecords(sharePartition, records2, 9);
sharePartition.acknowledge(MEMBER_ID, List.of(
- new ShareAcknowledgementBatch(5, 6, List.of((byte) 2)),
+ new ShareAcknowledgementBatch(5, 6,
List.of(AcknowledgeType.RELEASE.id)),
new ShareAcknowledgementBatch(10, 18, List.of(
- (byte) 2, (byte) 2, (byte) 2, (byte) 2, (byte) 2,
(byte) 0, (byte) 0, (byte) 0, (byte) 2
+ AcknowledgeType.RELEASE.id,
AcknowledgeType.RELEASE.id, AcknowledgeType.RELEASE.id,
AcknowledgeType.RELEASE.id, AcknowledgeType.RELEASE.id,
ACKNOWLEDGE_TYPE_GAP_ID, ACKNOWLEDGE_TYPE_GAP_ID, ACKNOWLEDGE_TYPE_GAP_ID,
AcknowledgeType.RELEASE.id
Review Comment:
Break the line now it's so long?
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -2820,7 +2820,7 @@ public void testAcknowledgeOutOfRangeCachedData() {
ackResult = sharePartition.acknowledge(
MEMBER_ID,
- List.of(new ShareAcknowledgementBatch(20, 25, List.of((byte) 3))));
+ List.of(new ShareAcknowledgementBatch(20, 25,
List.of(AcknowledgeType.RELEASE.id))));
Review Comment:
3 is REJECT :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
