chia7712 commented on code in PR #13938:
URL: https://github.com/apache/kafka/pull/13938#discussion_r2483764785
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -237,8 +239,8 @@ private void configureRLMM() {
rlmmProps.put(KafkaConfig.LogDirProp(), logDir);
rlmmProps.put("cluster.id", clusterId);
endpoint.ifPresent(e -> {
- rlmmProps.put("bootstrap.servers", e.host() + ":" + e.port());
- rlmmProps.put("security.protocol", e.securityProtocol().name);
+ rlmmProps.put(REMOTE_LOG_METADATA_COMMON_CLIENT_PREFIX +
"bootstrap.servers", e.host() + ":" + e.port());
+ rlmmProps.put(REMOTE_LOG_METADATA_COMMON_CLIENT_PREFIX +
"security.protocol", e.securityProtocol().name);
Review Comment:
What happens if "this" cluster uses security and the "target" uses
`PLAINTEXT`? Users might configure
`remote.log.metadata.common.client.bootstrap.servers` but omit
`remote.log.metadata.common.client.security.protocol`. It results in those
client components will mistakenly try to connect to the `PLAINTEXT` cluster
using `SSL/SASL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
