chia7712 commented on code in PR #20635:
URL: https://github.com/apache/kafka/pull/20635#discussion_r2483874107
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/TestUtils.java:
##########
@@ -35,6 +35,7 @@
* Helper functions for writing unit tests.
* <p>
* <b>Package-private:</b> Not intended for use outside {@code
org.apache.kafka.common.test}.
+ * Use {@code org/apache/kafka/test/TestUtils} instead.
Review Comment:
why we need this comment?
##########
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##########
@@ -742,4 +749,84 @@ public static ApiVersionsResponse
createApiVersionsResponse(
setZkMigrationEnabled(zkMigrationEnabled).
build();
}
+
+ public static MemoryRecords singletonRecords(byte[] value, byte[] key) {
Review Comment:
Could you move those helpers to `UnifiedLogTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
