chia7712 commented on code in PR #20806:
URL: https://github.com/apache/kafka/pull/20806#discussion_r2485579394
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -717,7 +717,7 @@ private void load() {
}
} catch (Throwable ex) {
log.error("Failed to load metadata from {} with
epoch {} due to {}.",
- tp, epoch, ex.toString());
+ tp, epoch, ex.toString(), ex);
Review Comment:
Because the whole exception `ex` is logged, changing `ex.toString()` to
`ex.getMessage()` would eliminate a lot of redundant information in the log
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -2446,7 +2446,7 @@ public void scheduleUnloadOperation(
// It's very unlikely that we will ever see an
exception here, since we
// already make an effort to catch exceptions in
the unload method.
log.error("Failed to unload metadata for {} with
epoch {} due to {}.",
- tp, partitionEpoch, ex.toString());
+ tp, partitionEpoch, ex.toString(), ex);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
