dajac commented on code in PR #20808:
URL: https://github.com/apache/kafka/pull/20808#discussion_r2485722072
##########
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorExecutorImplTest.java:
##########
@@ -167,8 +169,9 @@ public void testTaskFailedLifecycle() {
assertTrue(operationCalled.get());
}
- @Test
- public void testTaskCancelledBeforeBeingExecuted() {
+ @ParameterizedTest
+ @ValueSource(booleans = {false, true})
+ public void testTaskCancelledBeforeBeingExecuted(boolean useCancelAll) {
Review Comment:
I find the parameterisation weird here. Have you considered having a proper
unit test for the method itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
