adixitconfluent commented on code in PR #20815:
URL: https://github.com/apache/kafka/pull/20815#discussion_r2489588546
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -10081,6 +10153,8 @@ public void testLsoMovementWithPerOffsetRenewal()
throws InterruptedException {
assertEquals(RecordState.ACQUIRED, offset4.state());
assertNotNull(offset4.acquisitionLockTimeoutTask());
+ assertEquals(3, sharePartition.timer().size()); // Timer jobs - 3
because the renewed offsets are non-contiguous.
+
Mockito.verify(persister, Mockito.times(1)).writeState(Mockito.any());
Review Comment:
I feel in this test `testLsoMovementWithPerOffsetRenewal` particularly, we
should also test the acquisition lock expiry since there are some offsets that
are behind the start offset and have an active acquisition lock timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
