brandboat commented on code in PR #20672:
URL: https://github.com/apache/kafka/pull/20672#discussion_r2492503345
##########
server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:
##########
@@ -94,6 +98,7 @@ public static RequestContext
requestContextWithConnectionId(String connectionId)
false);
}
+ @SuppressWarnings("deprecation")
Review Comment:
Hi all, this should be replaced with removal. I got below warnings when
building kafka. fixed in https://github.com/apache/kafka/pull/20830.
```
/Users/brandboat/Code/kafka/kafka/server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:102:
warning: [removal] ClientTelemetryReceiver in
org.apache.kafka.server.telemetry has been deprecated and marked for removal
public static class TestClientMetricsReceiver implements
ClientTelemetryReceiver {
^
/Users/brandboat/Code/kafka/kafka/server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:130:
warning: [removal] ClientTelemetry in org.apache.kafka.server.telemetry has
been deprecated and marked for removal
public static class TestDualImplementation implements ClientTelemetry,
ClientTelemetryExporterProvider {
^
/Users/brandboat/Code/kafka/kafka/server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:140:
warning: [removal] ClientTelemetryReceiver in
org.apache.kafka.server.telemetry has been deprecated and marked for removal
public ClientTelemetryReceiver clientReceiver() {
^
```
```suggestion
@SuppressWarnings("removal")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
