AndrewJSchofield commented on code in PR #20822:
URL: https://github.com/apache/kafka/pull/20822#discussion_r2493560092
##########
clients/src/main/java/org/apache/kafka/common/internals/Topic.java:
##########
@@ -28,13 +28,14 @@ public class Topic {
public static final String TRANSACTION_STATE_TOPIC_NAME =
"__transaction_state";
public static final String SHARE_GROUP_STATE_TOPIC_NAME =
"__share_group_state";
public static final String CLUSTER_METADATA_TOPIC_NAME =
"__cluster_metadata";
+ public static final String REMOTE_LOG_METADATA_TOPIC_NAME =
"__remote_log_metadata";
public static final TopicPartition CLUSTER_METADATA_TOPIC_PARTITION = new
TopicPartition(
CLUSTER_METADATA_TOPIC_NAME,
0
);
public static final String LEGAL_CHARS = "[a-zA-Z0-9._-]";
- private static final Set<String> INTERNAL_TOPICS =
Set.of(GROUP_METADATA_TOPIC_NAME, TRANSACTION_STATE_TOPIC_NAME,
SHARE_GROUP_STATE_TOPIC_NAME);
+ private static final Set<String> INTERNAL_TOPICS =
Set.of(GROUP_METADATA_TOPIC_NAME, TRANSACTION_STATE_TOPIC_NAME,
SHARE_GROUP_STATE_TOPIC_NAME, REMOTE_LOG_METADATA_TOPIC_NAME);
Review Comment:
You may be correct, but I think the main difference is that internal topics
are filtered out of listing topics by default. I do think that we need to tread
carefully here. If there is any doubt about making this an internal topic, we
should not do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
