mjsax commented on code in PR #20326:
URL: https://github.com/apache/kafka/pull/20326#discussion_r2496927859
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java:
##########
@@ -782,16 +782,18 @@ public void shouldCompleteTopicValidationOnRetry() {
// let the first describe succeed on topic, and fail on topic2, and
then let creation throws topics-existed;
// it should retry with just topic2 and then let it succeed
when(admin.describeTopics(Set.of(topic1, topic2)))
- .thenAnswer(answer -> new MockDescribeTopicsResult(mkMap(
- mkEntry(topic1, topicDescriptionSuccessFuture),
- mkEntry(topic2, topicDescriptionFailFuture)
- )));
+ .thenAnswer(answer -> new MockDescribeTopicsResult(mkMap(
+ mkEntry(topic1, topicDescriptionSuccessFuture),
+ mkEntry(topic2, topicDescriptionFailFuture) // first
call: missing
+ )))
+ .thenAnswer(answer -> new MockDescribeTopicsResult(mkMap(
+ mkEntry(topic1, topicDescriptionSuccessFuture),
Review Comment:
Why do we return topic1 here again? The original code only returned `topic2`
in the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
