squah-confluent commented on code in PR #20755:
URL: https://github.com/apache/kafka/pull/20755#discussion_r2500045819
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8570,6 +8645,8 @@ private boolean maybeDeleteEmptyStreamsGroup(String
groupId, List<CoordinatorRec
// Add tombstones for the previous streams group. The tombstones
won't actually be
// replayed because its coordinator result has a non-null
appendFuture.
createGroupTombstoneRecords(group, records);
+ // Cancel initial rebalance timer.
+ timer.cancel(streamsInitialRebalanceKey(groupId));
Review Comment:
It's an odd place to move the cancellation, purely because of the naming,
but I can't see where else it'd go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
