hermanjakobsen commented on code in PR #19937:
URL: https://github.com/apache/kafka/pull/19937#discussion_r2503589643
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ForwardingDisabledProcessorContext.java:
##########
@@ -93,7 +94,15 @@ public <S extends StateStore> S getStateStore(final String
name) {
public Cancellable schedule(final Duration interval,
final PunctuationType type,
final Punctuator callback) throws
IllegalArgumentException {
- return delegate.schedule(interval, type, callback);
+ return delegate.schedule(null, interval, type, callback);
Review Comment:
I think I'm more fond of `Optional<Instant>`. Using `Instant.EPOCH` makes it
difficult to distinguish between a user not specifying a `startTime` (i.e.
would like to use none-anchored punctuation) and a user that would actually
like to use `Instant.EPOCH` as the `startTime` for the anchored punctuation.
An present `Instant` for the `startTime` is used by the internal methods to
decide whether the punctuation should be anchored or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
