lianetm commented on code in PR #19577:
URL: https://github.com/apache/kafka/pull/19577#discussion_r2512163018
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -1584,20 +1643,33 @@ private void
sendAndVerifyOffsetCommitRequestFailedAndMaybeRetried(
private List<NetworkClientDelegate.FutureCompletionHandler> assertPoll(
final int numRes,
final CommitRequestManager manager) {
- return assertPoll(true, numRes, manager);
+ return assertPoll(true, numRes, manager, false);
}
private List<NetworkClientDelegate.FutureCompletionHandler> assertPoll(
final boolean coordinatorDiscovered,
final int numRes,
final CommitRequestManager manager) {
+ return assertPoll(coordinatorDiscovered, numRes, manager, false);
+ }
+
+ private List<NetworkClientDelegate.FutureCompletionHandler> assertPoll(
+ final boolean coordinatorDiscovered,
+ final int numRes,
+ final CommitRequestManager manager,
+ final boolean shouldUseTopicIds) {
if (coordinatorDiscovered) {
when(coordinatorRequestManager.coordinator()).thenReturn(Optional.of(mockedNode));
} else {
when(coordinatorRequestManager.coordinator()).thenReturn(Optional.empty());
}
NetworkClientDelegate.PollResult res =
manager.poll(time.milliseconds());
assertEquals(numRes, res.unsentRequests.size());
+ if (shouldUseTopicIds) {
+ res.unsentRequests.stream()
+ .flatMap(request -> ((OffsetCommitRequestData)
request.requestBuilder().build().data()).topics().stream())
+ .forEach(topic -> assertNotEquals(Uuid.ZERO_UUID,
topic.topicId()));
Review Comment:
should we also check the request version set is the one that will actually
use the topic IDs?
`req.requestBuilder().latestAllowedVersion() > 9` (otherwise the topicIDs
contained in the data won't be actually send I expect)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
