jolshan commented on code in PR #20868:
URL: https://github.com/apache/kafka/pull/20868#discussion_r2520428567
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -2827,7 +2827,7 @@ private EndTxnResponse createEndTxnResponse() {
private WriteTxnMarkersRequest createWriteTxnMarkersRequest(short version)
{
List<TopicPartition> partitions = singletonList(new
TopicPartition("topic", 73));
WriteTxnMarkersRequest.TxnMarkerEntry txnMarkerEntry = new
WriteTxnMarkersRequest.TxnMarkerEntry(21L, (short) 42, 73,
TransactionResult.ABORT, partitions);
- return new
WriteTxnMarkersRequest.Builder(singletonList(txnMarkerEntry)).build(version);
+ return new
WriteTxnMarkersRequest.Builder(singletonList(txnMarkerEntry),
null).build(version);
Review Comment:
Do we want to add any tests here with the transactionVersions param? If the
tests don't use it, we don't need to, but just want to confirm there isn't any
other coverage we want here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
