mjsax commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2520688773
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -772,7 +773,7 @@ private StateUpdater.RemovedTaskResult waitForFuture(final
TaskId taskId,
final
CompletableFuture<StateUpdater.RemovedTaskResult> future) {
final StateUpdater.RemovedTaskResult removedTaskResult;
try {
- removedTaskResult = future.get();
+ removedTaskResult = future.get(1, TimeUnit.MINUTES);
Review Comment:
I was thinking about this again. Adding the timeout is the right thing to
do, but one minute might be a little bit too aggressive? Should we increase
this to maybe 5, of even 10 minutes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
